From bounce-debian-bugs-dist==chris-lamb.co.uk@lists.debian.org Sun Apr 20 14:31:03 2008
Received: from liszt.debian.org ([82.195.75.100])
	by chris-lamb.co.uk with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.63)
	(envelope-from <bounce-debian-bugs-dist==chris-lamb.co.uk@lists.debian.org>)
	id 1JnZdC-0007B2-EQ
	for bot.address@chris-lamb.co.uk; Sun, 20 Apr 2008 14:31:03 +0100
Received: from localhost (localhost [127.0.0.1])
	by liszt.debian.org (Postfix) with QMQP
	id BB72013A4FBF; Sun, 20 Apr 2008 13:30:56 +0000 (UTC)
Old-Return-Path: <debbugs@rietz.debian.org>
X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on liszt.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.9 required=4.0 tests=BAYES_00,FOURLA,LDO_WHITELIST,
	MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3
X-Original-To: debian-bugs-dist@lists.debian.org
Delivered-To: lists-debian-bugs-dist@liszt.debian.org
Received: from rietz.debian.org (rietz.debian.org [140.211.166.43])
	by liszt.debian.org (Postfix) with ESMTP id 9CC3013A4EDF;
	Sun, 20 Apr 2008 13:30:42 +0000 (UTC)
Received: from debbugs by rietz.debian.org with local (Exim 4.63)
	(envelope-from <debbugs@rietz.debian.org>)
	id 1JnZZO-00019M-J7; Sun, 20 Apr 2008 13:27:02 +0000
X-Loop: owner@bugs.debian.org
Subject: Bug#389068: Jabref patch
Reply-To: gregor herrmann <gregoa@debian.org>, 389068@bugs.debian.org
Resent-From: gregor herrmann <gregoa@debian.org>
Resent-To: debian-bugs-dist@lists.debian.org
Resent-CC: gregor herrmann <gregor+debian@comodo.priv.at>
Resent-Date: Sun, 20 Apr 2008 13:27:01 +0000
Resent-Message-ID: <handler.389068.B389068.120869784031581@bugs.debian.org>
X-Debian-PR-Message: followup 389068
X-Debian-PR-Package: jabref
X-Debian-PR-Keywords: patch
X-Debian-PR-Source: jabref
Received: via spool by 389068-submit@bugs.debian.org id=B389068.120869784031581
          (code B ref 389068); Sun, 20 Apr 2008 13:27:01 +0000
Received: (at 389068) by bugs.debian.org; 20 Apr 2008 13:24:00 +0000
X-Amavis-Spam-Status: No, score=-8.7 required=4.0 tests=BAYES_00,FORGED_RCVD_HELO,
	FOURLA,FROMDEVELOPER,HAS_BUG_NUMBER,MURPHY_DRUGS_REL8 autolearn=no 
	version=3.1.4-bugs.debian.org_2005_01_02
Received: from colleen.colgarra.priv.at ([82.150.197.85])
	by rietz.debian.org with esmtp (Exim 4.63)
	(envelope-from <gregoa@debian.org>)
	id 1JnZWR-0008D9-U3
	for 389068@bugs.debian.org; Sun, 20 Apr 2008 13:24:00 +0000
Received: from chello080109165251.tirol.surfer.at ([80.109.165.251] helo=belanna.comodo.priv.at)
	by colleen.colgarra.priv.at with esmtpsa (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.63)
	(envelope-from <gregoa@debian.org>)
	id 1JnZWQ-0000Rs-9e; Sun, 20 Apr 2008 15:23:58 +0200
Received: from gregoa by belanna.comodo.priv.at with local (Exim 4.69)
	(envelope-from <gregoa@debian.org>)
	id 1JnZWP-000347-CH; Sun, 20 Apr 2008 15:23:57 +0200
Date: Sun, 20 Apr 2008 15:23:57 +0200
From: gregor herrmann <gregoa@debian.org>
To: Gerardo Curiel <gcuriel@debian.org.ve>, 389068@bugs.debian.org
Cc: Tony Mancill <tmancill@debian.org>
Message-ID: <20080420132357.GM4935@belanna.comodo.priv.at>
References: <1208643762.5805.32.camel@sophie.gerardo.com.ve>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="uWbmMdDzzl2TXAgx"
Content-Disposition: inline
In-Reply-To: <1208643762.5805.32.camel@sophie.gerardo.com.ve>
X-Face: -kg'V!M2hYTiiEt:oj$rToa+c^7N.t}]V^j}|%+]%3J&tOm^9mc^1-#9o=\8VJpV7b~n
	xIM!qu>r_:w\EtWQA01;$jp>,cgp9EWV:i9B]LCgiNn\jA=un9d-ZcRzyq~9vYUf*tx9
	B}de^fH5Q(d(_N"0WXs%Jh!~.*g.iC=bSTqL:/EE0Y~\g_QCvwS6=cv]$tB7z<Xh[Wxa
	.2d"m?]^f
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Resent-Date: Sun, 20 Apr 2008 13:27:02 +0000
X-Debian-Message: from BTS
X-Rc-Virus: 2007-09-13_01
X-Rc-Spam: 2007-10-04_01
X-Mailing-List: <debian-bugs-dist@lists.debian.org> archive/latest/343494
X-Loop: debian-bugs-dist@lists.debian.org
List-Id: <debian-bugs-dist.lists.debian.org>
List-Post: <mailto:debian-bugs-dist@lists.debian.org>
List-Help: <mailto:debian-bugs-dist-request@lists.debian.org?subject=help>
List-Subscribe: <mailto:debian-bugs-dist-request@lists.debian.org?subject=subscribe>
List-Unsubscribe: <mailto:debian-bugs-dist-request@lists.debian.org?subject=unsubscribe>
Precedence: list
Resent-Sender: debian-bugs-dist-request@lists.debian.org
Received-SPF: none
X-SPF-Guess: pass
X-Spam-Score: -52.5
X-Spam-Report: (-52.5 points, 5.0 required)
	pts rule name              description
	---- ---------------------- --------------------------------------------------
	-50 D_FOR_BOT              For debian-devel-changes bot
	0.1 FORGED_RCVD_HELO       Received: contains a forged HELO
	0.0 UNPARSEABLE_RELAY      Informational: message has unparseable relay lines
	-2.6 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0000]


--uWbmMdDzzl2TXAgx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, 19 Apr 2008 17:52:42 -0430, Gerardo Curiel wrote:

> * 05build_with_debian_jars: use the java libraries from /usr/share/java,
> and disable the 'unjarlib' target dependency from the 'jars' target.
> Instead of include the whole set of classes in the same jar, Jabref now
> use the libraries in the classpath to compile and run(see
> jabref-wrapper).

Integrated as 02_libs.dpatch (fits better in the order of patches
:)), the changes to unjarlib were missing in my last version.
=20
> Additionaly, I've commented the 'jarbundler' target, It's a
> macosx-specific target, and uses the lib/jarbundler-1.4.jar(not in
> debian and useless), which makes ant unhappy if not present.=20

That doesn't really work because the patches are not applied when
debian/rules clean target is called. I've been stumbling over this
issue already last weekend, and I'm not really sure what to do about
it; either ignore it (which means leaving lib/ around) or patching
build.xml directly (which is ugly) or ...?
=20
> So you can repackage the upstream tarball and remove those jarfiles and
> make it DFSG-Free.

I'm not sure this is really necessary, the problem is not that the
jars are not free but that they are used by the build system. All we
would gain is a decrease in size of the .orig.tar.gz.
=20
> * Moved jabref script to debian/ , renamed jabref-wrapper(as you already
> did in the trunk version) and add the needed jars to the Classpath.=20

I've added the classpath line as proposed.
=20
> * Added new Dependencies and Build-Dependencies to debian/control.
> Jabref still depends on both antlr and antlr3, and it just works using
> libjempbox-java (>=3D 0.2.0)

Depends: adjusted (B-D-I was already changed)
=20
> * 06proposed_upstream_fix_ruleNestingLevel: Upstream still uses antlr3
> beta, the debian version is the stable one, this patch allows using the
> debian version. I've not tested extensively, but it works for me :).

Integrated as 05_antlr.dpatch; that was my "old" name but your patch
is much better than my first attempt!
=20
I've reorganized my svn repository a bit, so that 2.3 is in trunk
again, and the new 2.4-beta is in branches/2.4:
http://svn.toastfreeware.priv.at/debian/jabref/trunk
http://svn.toastfreeware.priv.at/debian/jabref/branches/2.4


Thanks again for your help!

Cheers,
gregor
--=20
 .''`.   http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4
 : :' :  debian gnu/linux user, admin & developer - http://www.debian.org/
 `. `'   member of https://www.vibe.at/ | how to reply: http://got.to/quote/
   `-    NP: Rolling Stones

--uWbmMdDzzl2TXAgx
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIC0PsOzKYnQDzz+QRAhDHAKDI++9HKX1Mzse6PxJAtZa8HuLi3QCg7Yt2
3WYZ8QJRP1s0vkwQJlqdiPM=
=G/rI
-----END PGP SIGNATURE-----

--uWbmMdDzzl2TXAgx--



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org


