From bounce-debian-bugs-dist==chris-lamb.co.uk@lists.debian.org Sun Apr 20 15:30:22 2008
Received: from liszt.debian.org ([82.195.75.100])
	by chris-lamb.co.uk with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.63)
	(envelope-from <bounce-debian-bugs-dist==chris-lamb.co.uk@lists.debian.org>)
	id 1JnaYX-0007RU-Me
	for bot.address@chris-lamb.co.uk; Sun, 20 Apr 2008 15:30:22 +0100
Received: from localhost (localhost [127.0.0.1])
	by liszt.debian.org (Postfix) with QMQP
	id 5293D13A4EBC; Sun, 20 Apr 2008 14:30:12 +0000 (UTC)
Old-Return-Path: <debbugs@rietz.debian.org>
X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on liszt.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.5 required=4.0 tests=BAYES_00,LDO_WHITELIST,
	MURPHY_DRUGS_REL8,PHONENUMBER,RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3
X-Original-To: debian-bugs-dist@lists.debian.org
Delivered-To: lists-debian-bugs-dist@liszt.debian.org
Received: from rietz.debian.org (rietz.debian.org [140.211.166.43])
	by liszt.debian.org (Postfix) with ESMTP id B90F113A4EA1;
	Sun, 20 Apr 2008 14:29:59 +0000 (UTC)
Received: from debbugs by rietz.debian.org with local (Exim 4.63)
	(envelope-from <debbugs@rietz.debian.org>)
	id 1JnaVU-000495-7q; Sun, 20 Apr 2008 14:27:04 +0000
X-Loop: owner@bugs.debian.org
Subject: Bug#476806: AssertionError when archiving empty maildirs
Reply-To: Nikolaus Schulz <microschulz@web.de>, 476806@bugs.debian.org
Resent-From: Nikolaus Schulz <microschulz@web.de>
Original-Sender: microschulz@web.de
Resent-To: debian-bugs-dist@lists.debian.org
Resent-CC: Joey Hess <joeyh@debian.org>
Resent-Date: Sun, 20 Apr 2008 14:27:03 +0000
Resent-Message-ID: <handler.476806.B476806.12087014619441@bugs.debian.org>
X-Debian-PR-Message: followup 476806
X-Debian-PR-Package: archivemail
X-Debian-PR-Keywords: 
X-Debian-PR-Source: archivemail
Received: via spool by 476806-submit@bugs.debian.org id=B476806.12087014619441
          (code B ref 476806); Sun, 20 Apr 2008 14:27:03 +0000
Received: (at 476806) by bugs.debian.org; 20 Apr 2008 14:24:21 +0000
X-Amavis-Spam-Status: No, score=-10.3 required=4.0 tests=BAYES_00,FORGED_RCVD_HELO,
	HAS_BUG_NUMBER,MURPHY_DRUGS_REL8,PHONENUMBER,VALID_BTS_CONTROL,
	X_DEBBUGS_NO_ACK autolearn=no version=3.1.4-bugs.debian.org_2005_01_02
Received: from fmmailgate03.web.de ([217.72.192.234])
	by rietz.debian.org with esmtp (Exim 4.63)
	(envelope-from <microschulz@web.de>)
	id 1JnaSr-0002Ki-1o; Sun, 20 Apr 2008 14:24:21 +0000
Received: from smtp05.web.de (fmsmtp05.dlan.cinetic.de [172.20.4.166])
	by fmmailgate03.web.de (Postfix) with ESMTP id 6468BD7BC075;
	Sun, 20 Apr 2008 16:24:14 +0200 (CEST)
Received: from [83.125.40.75] (helo=tunichtgut.zusammrottung.local)
	by smtp05.web.de with asmtp (TLSv1:AES256-SHA:256)
	(WEB.DE 4.109 #226)
	id 1JnaSj-0000nC-00; Sun, 20 Apr 2008 16:24:14 +0200
Received: from zorro.zusammrottung.local
	([192.168.178.206] helo=localhost ident=Debian-exim)
	by tunichtgut.zusammrottung.local with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.63)
	(envelope-from <nikolaus@zorro.zusammrottung.local>)
	id 1JnaSi-0006Su-Gt; Sun, 20 Apr 2008 16:24:12 +0200
Received: from nikolaus by localhost with local (Exim 4.69)
	(envelope-from <nikolaus@zorro.zusammrottung.local>)
	id 1JnaSX-0002Fe-JU; Sun, 20 Apr 2008 16:24:01 +0200
Date: Sun, 20 Apr 2008 16:24:01 +0200
From: Nikolaus Schulz <microschulz@web.de>
To: Joey Hess <joeyh@debian.org>, 476806@bugs.debian.org
Cc: Julien Danjou <acid@debian.org>, control@bugs.debian.org
Message-ID: <20080420142401.GA3729@zorro.zusammrottung.local>
References: <20080419100723.GA29948@abydos.adm.naquadah.org> <20080419203805.GA21036@kodama.kitenet.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="XF85m9dhOBO43t/C"
Content-Disposition: inline
In-Reply-To: <20080419203805.GA21036@kodama.kitenet.net>
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Sender: microschulz@web.de
X-Sender: microschulz@web.de
X-Provags-ID: V01U2FsdGVkX1+1jupOQ8BJ/M0GBGrR2bc3Mm3bsBzK9AfPHSjs
	u/lnUaC30+nN+5Wp59GPNNUpZEKaiAU+AcRH4lPGOKb8ibgOPq
	kKEZBwsBw=
Resent-Date: Sun, 20 Apr 2008 14:27:04 +0000
X-Debian-Message: from BTS
X-Rc-Virus: 2007-09-13_01
X-Rc-Spam: 2007-10-04_01
X-Mailing-List: <debian-bugs-dist@lists.debian.org> archive/latest/343523
X-Loop: debian-bugs-dist@lists.debian.org
List-Id: <debian-bugs-dist.lists.debian.org>
List-Post: <mailto:debian-bugs-dist@lists.debian.org>
List-Help: <mailto:debian-bugs-dist-request@lists.debian.org?subject=help>
List-Subscribe: <mailto:debian-bugs-dist-request@lists.debian.org?subject=subscribe>
List-Unsubscribe: <mailto:debian-bugs-dist-request@lists.debian.org?subject=unsubscribe>
Precedence: list
Resent-Sender: debian-bugs-dist-request@lists.debian.org
Received-SPF: none
X-SPF-Guess: pass
X-Spam-Score: -40.8
X-Spam-Report: (-40.8 points, 5.0 required)
	pts rule name              description
	---- ---------------------- --------------------------------------------------
	-50 D_FOR_BOT              For debian-devel-changes bot
	0.1 FORGED_RCVD_HELO       Received: contains a forged HELO
	0.0 UNPARSEABLE_RELAY      Informational: message has unparseable relay lines
	-2.6 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0000]
	12 AWL                    AWL: From: address is in the auto white-list


--XF85m9dhOBO43t/C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

tags 476806 + patch 
thanks

On Sat, Apr 19, 2008 at 04:38:05PM -0400, Joey Hess wrote:
> Julien Danjou wrote:
> > First of all, I'm making this bug serious since it breaks the software
> > for me, but feel free to downgrade.

Unless you feed multiple mailboxes to archivemail in one go, I don't see
how this breaks anything, apart from firing annoying warnings. 

I'm attaching the trivial fix from upstream.  Note that the problem has
been reported before, see issue #1878940 at sf.net[1].  

> The bug seems to be that under python 2.5, a mailbox.Maildir object that
> is empty evaluates to a false value, while in previous versions of python,
> the same object would evaluate to true:
<snip>
> I don't know enough python to say, but this looks rather like a bug or
> incompatible change in python 2.5.
> 
> If so, this kind of change in python would certianly seem likely to break
> lots of other stuff, so perhaps your severity isn't so inflated after all.

You are correct, the mailbox module has been rewritten in Python 2.5.
They have put most of the new code into new classes, keeping the old
classes around for backward compatiblity; but the Maildir class was
rewritten, and the boolean value of an empty maildir has changed to
False.  While this probably counts as a python bug, I don't know if it
qualifies as serious.

BTW, this is not the only breakage I've seen due to the new Maildir
class[2]. 

Nikolaus

[1]
http://sourceforge.net/tracker/index.php?func=detail&aid=1878940&group_id=49630&atid=456912
[2]
http://sourceforge.net/tracker/index.php?func=detail&aid=1670422&group_id=49630&atid=456910

--XF85m9dhOBO43t/C
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="maildir2.5-fix.diff"

Index: archivemail.py
===================================================================
--- archivemail.py	(revision 265)
+++ archivemail.py	(revision 266)
@@ -1287,7 +1287,6 @@
         original = mailbox.MHMailbox(mailbox_name)
     else:
         unexpected_error("unknown type: %s" % type)        
-    assert(original)
 
     cache = IdentityCache(mailbox_name)
 

--XF85m9dhOBO43t/C--



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org


