From bounce-debian-bugs-dist==chris-lamb.co.uk@lists.debian.org Sun Apr 20 16:00:51 2008
Received: from liszt.debian.org ([82.195.75.100])
	by chris-lamb.co.uk with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.63)
	(envelope-from <bounce-debian-bugs-dist==chris-lamb.co.uk@lists.debian.org>)
	id 1Jnb25-0007bs-8O
	for bot.address@chris-lamb.co.uk; Sun, 20 Apr 2008 16:00:51 +0100
Received: from localhost (localhost [127.0.0.1])
	by liszt.debian.org (Postfix) with QMQP
	id 4BA6313A4FE6; Sun, 20 Apr 2008 15:00:44 +0000 (UTC)
Old-Return-Path: <debbugs@rietz.debian.org>
X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on liszt.debian.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.7 required=4.0 tests=BAYES_00,FOURLA,
	IMPRONONCABLE_1,LDO_WHITELIST,MURPHY_DRUGS_REL8,MURPHY_WRONG_WORD2,
	RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3
X-Original-To: debian-bugs-dist@lists.debian.org
Delivered-To: lists-debian-bugs-dist@liszt.debian.org
Received: from rietz.debian.org (rietz.debian.org [140.211.166.43])
	by liszt.debian.org (Postfix) with ESMTP id 15D2313A5012;
	Sun, 20 Apr 2008 15:00:30 +0000 (UTC)
Received: from debbugs by rietz.debian.org with local (Exim 4.63)
	(envelope-from <debbugs@rietz.debian.org>)
	id 1JnayY-0001dU-Am; Sun, 20 Apr 2008 14:57:06 +0000
X-Loop: owner@bugs.debian.org
Subject: Bug#476863: source-highlight: Patch which makes stdout the default as well as adds "-" to enable stdout
Reply-To: opal@debian.org, 476863@bugs.debian.org
Resent-From: Ola Lundqvist <opal@debian.org>
Resent-To: debian-bugs-dist@lists.debian.org
Resent-CC: Ola Lundqvist <opal@debian.org>
Resent-Date: Sun, 20 Apr 2008 14:57:05 +0000
Resent-Message-ID: <handler.476863.B476863.120870321632449@bugs.debian.org>
X-Debian-PR-Message: followup 476863
X-Debian-PR-Package: source-highlight
X-Debian-PR-Keywords: 
X-Debian-PR-Source: source-highlight
Received: via spool by 476863-submit@bugs.debian.org id=B476863.120870321632449
          (code B ref 476863); Sun, 20 Apr 2008 14:57:05 +0000
Received: (at 476863) by bugs.debian.org; 20 Apr 2008 14:53:36 +0000
X-Amavis-Spam-Status: No, score=-7.5 required=4.0 tests=BAYES_00,FORGED_RCVD_HELO,
	FOURLA,FROMDEVELOPER,HAS_BUG_NUMBER,IMPRONONCABLE_1,MURPHY_DRUGS_REL8,
	MURPHY_WRONG_WORD2 autolearn=no 
	version=3.1.4-bugs.debian.org_2005_01_02
Received: from c-adt-5.ataco.se ([213.115.168.248] helo=bixbite.inguza.net)
	by rietz.debian.org with esmtp (Exim 4.63)
	(envelope-from <ola@inguza.net>)
	id 1Jnav9-0008Qq-LF
	for 476863@bugs.debian.org; Sun, 20 Apr 2008 14:53:36 +0000
Received: from ola by bixbite.inguza.net with local (Exim 4.63)
	(envelope-from <ola@inguza.net>)
	id 1Jnav2-0002vw-1D; Sun, 20 Apr 2008 16:53:28 +0200
Date: Sun, 20 Apr 2008 16:53:28 +0200
From: Ola Lundqvist <opal@debian.org>
To: Kresten Kjeldgaard <gathond@gathond.dk>, 476863@bugs.debian.org
Message-ID: <20080420145328.GA9763@inguza.net>
References: <20080419173843.31158.93249.reportbug@laptop.gathond.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080419173843.31158.93249.reportbug@laptop.gathond.dk>
User-Agent: Mutt/1.5.13 (2006-08-11)
Resent-Date: Sun, 20 Apr 2008 14:57:06 +0000
X-Debian-Message: from BTS
X-Rc-Virus: 2007-09-13_01
X-Rc-Spam: 2007-10-04_01
X-Mailing-List: <debian-bugs-dist@lists.debian.org> archive/latest/343545
X-Loop: debian-bugs-dist@lists.debian.org
List-Id: <debian-bugs-dist.lists.debian.org>
List-Post: <mailto:debian-bugs-dist@lists.debian.org>
List-Help: <mailto:debian-bugs-dist-request@lists.debian.org?subject=help>
List-Subscribe: <mailto:debian-bugs-dist-request@lists.debian.org?subject=subscribe>
List-Unsubscribe: <mailto:debian-bugs-dist-request@lists.debian.org?subject=unsubscribe>
Precedence: list
Resent-Sender: debian-bugs-dist-request@lists.debian.org
Received-SPF: none
X-SPF-Guess: pass
X-Spam-Score: -38.5
X-Spam-Report: (-38.5 points, 5.0 required)
	pts rule name              description
	---- ---------------------- --------------------------------------------------
	-50 D_FOR_BOT              For debian-devel-changes bot
	0.1 FORGED_RCVD_HELO       Received: contains a forged HELO
	0.0 UNPARSEABLE_RELAY      Informational: message has unparseable relay lines
	-2.6 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0000]
	14 AWL                    AWL: From: address is in the auto white-list

Hi

Thanks a lot for the patch. I'm not sure I want to change the default compared to
"upstream". I would actually prefer to change the documentation in that case.

Do you have an other opinion about this?

Best regards,

// Ola

On Sat, Apr 19, 2008 at 07:38:43PM +0200, Kresten Kjeldgaard wrote:
> Package: source-highlight
> Version: 2.4-5.2
> Followup-For: Bug #476863
> 
> The attached patch fixes the broken default as well as adds "-" along with
> "STDOUT" as special filenames. 
> 
> -- System Information:
> Debian Release: lenny/sid
>   APT prefers unstable
>   APT policy: (500, 'unstable')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 2.6.24-1-amd64 (SMP w/2 CPU cores)
> Locale: LANG=en_GB.ISO-8859-15, LC_CTYPE=da_DK.ISO-8859-15 (charmap=ISO-8859-15)
> Shell: /bin/sh linked to /bin/bash
> 
> Versions of packages source-highlight depends on:
> ii  libboost-regex1.34.1          1.34.1-11  regular expression library for C++
> ii  libc6                         2.7-10     GNU C Library: Shared libraries
> ii  libgcc1                       1:4.3.0-3  GCC support library
> ii  libstdc++6                    4.3.0-3    The GNU Standard C++ Library v3
> 
> source-highlight recommends no packages.
> 
> -- no debconf information

> --- source-highlight-2.4/src/startapp.cc	2006-05-07 15:00:32.000000000 +0200
> +++ source-highlight-2.4-fixed/src/startapp.cc	2008-04-19 19:06:03.529843322 +0200
> @@ -181,9 +181,10 @@
>    if ( inputFileName.size() && ! is_cgi && args_info.output_given)
>      outputFileName = args_info.output_arg ;
>  
> -  bool generate_to_stdout =
> +  bool generate_to_stdout = (!args_info.output_arg || 
>      (args_info.output_arg &&
> -     strcmp (args_info.output_arg, "STDOUT") == 0);
> +		 (strcmp (args_info.output_arg, "STDOUT") == 0 || 
> +		 strcmp (args_info.output_arg, "-") == 0)));
>  
>    if ( verbose )
>      setMessager( new DefaultMessages ) ;


-- 
 --------------------- Ola Lundqvist ---------------------------
/  opal@debian.org                     Annebergsslingan 37      \
|  ola@inguza.com                      654 65 KARLSTAD          |
|  http://inguza.com/                  +46 (0)70-332 1551       |
\  gpg/f.p.: 7090 A92B 18FE 7994 0C36  4FE4 18A1 B1CF 0FE5 3DD9 /
 ---------------------------------------------------------------



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org


